Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image changes #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Image changes #251

wants to merge 1 commit into from

Conversation

IsaacPimentel73
Copy link

Both favicon.png and apple-touch-icon.png were removed.

@vitormattos
Copy link
Member

Copy link
Author

@IsaacPimentel73 IsaacPimentel73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Dco problem.

Signed-off-by: IsaacPimentel73 <[email protected]>
Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ok?

Looking the code I found two places that those files are used:

<link href="{{ $page->baseUrl }}assets/images/favico.png" rel="icon">
<link href="{{ $page->baseUrl }}assets/images/apple-touch-icon.png" rel="apple-touch-icon">

Do these images appear somewhere or in some way? If so, where and how do these images appear on the website?

At the original PR have questions to be answered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants