[#152] Test: created integration test for supabase/middleware #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexappleget
requested review from
HoldUpFjord,
jennifertieu,
kepsteen and
shashilo
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mathematiCode
requested changes
May 13, 2025
Contributor
mathematiCode
left a comment
mathematiCode
left a comment
There was a problem hiding this comment.
I think it's fine to mock the page redirects, but I do think we should have an actual test database with test users to make sure they can only access the appropriate pages. Otherwise, really nice job on this!
…tegration-test-for-supabase-middleware
alexappleget
force-pushed
the
alex/152-create-integration-test-for-supabase-middleware
branch
from
2a5e5bd to
692ade2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152
All tests pass and I double checked by forcing them to fail to make sure it was testing correctly.
And since I touched the middleware file to move it into its own folder and write a test for it, I handled the eslint errors for the
middleware.tsas well.IMPORTANT: I edited the
middleware.tsfile because it was needed to even make any of these tests pass and be accurate.