Feature/#55 frontend detail of the reservoir capacity chart #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or visual representation
…, to display reservoir data
… to ensure valid arc rendering
…ut and text alignment
brauliodiez
reviewed
Dec 10, 2025
| return ( | ||
| <div className="flex flex-col gap-8"> | ||
| <h2>Detalle del embalse: {embalse}</h2> | ||
| <ReservoirGauge name={embalse} {...reservoirData} /> |
Member
There was a problem hiding this comment.
Usar esto es un poco peligroso
<ReservoirGauge name={embalse} {...reservoirData} />El problema de usar el spread operator aquí es que si le pasamos más propiedades se las come, y si por ejemplo quisieramos optimizar para que sólo se redibujara si cambia alguna propiedad, esas propiedades de más se colarían.
¿Que interfaz tiene mock data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Reservoir Capacity Gauge Chart
Adds a D3.js-based gauge chart component to visualize reservoir capacity.
Features:
TODO:
Close #55