Skip to content

Automated fix for refs/heads/improve-RunList #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: improve-RunList
Choose a base branch
from
Open

Automated fix for refs/heads/improve-RunList #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f838f6f
Improve "ExecCtx::RunList()" with O(1) implementation.
Mar 7, 2023
cc7424f
Automated change: Fix sanity tests
LeiW000 Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions src/core/lib/iomgr/exec_ctx.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,27 +106,18 @@ void ExecCtx::Run(const DebugLocation& location, grpc_closure* closure,
}

void ExecCtx::RunList(const DebugLocation& location, grpc_closure_list* list) {
(void)location;
grpc_closure* c = list->head;
while (c != nullptr) {
grpc_closure* next = c->next_data.next;
#ifndef NDEBUG
if (c->scheduled) {
Crash(absl::StrFormat(
"Closure already scheduled. (closure: %p, created: [%s:%d], "
"previously scheduled at: [%s: %d], newly scheduled at [%s:%d]",
c, c->file_created, c->line_created, c->file_initiated,
c->line_initiated, location.file(), location.line()));
grpc_closure_list* destlist = ExecCtx::Get()->closure_list();

if (list->head != nullptr) {
if (destlist->head == nullptr) {
destlist->head = list->head;
destlist->tail = list->tail;
} else {
destlist->tail->next_data.next = list->head;
destlist->tail = list->tail;
}
c->scheduled = true;
c->file_initiated = location.file();
c->line_initiated = location.line();
c->run = false;
GPR_ASSERT(c->cb != nullptr);
#endif
exec_ctx_sched(c);
c = next;
}

list->head = list->tail = nullptr;
}

Expand Down