Pkcs7 #87
Open
Pkcs7 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siccegge
force-pushed
the
pkcs7
branch
2 times, most recently
from
4617b06
to
8b4da8a
Compare
- Can decrypt a RSA PKCS1.5 message with AES data encryption - lacks much of general algorithm support which should be "easy" now - lacks all of proper error handling / reporting - lacks documentation - lacks tests
|
Hi again! This is now mostly enough of a hack to do what I immediately need. I haven't really figured out how to deal with the BER stuff. I'm thinking of making the Der/Ber/.. thing a mixin to the existing datatypes maybe. What are your opinions on using an already existing external asn.1 library? |
|
PKCS#7 is now supported: This pull request should be closed. @siccegge did you receive this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm currently in need for PKCS#7 support and therefore looking into it. Obviously the current state (as in this PR) is crap and should not be used as-is. However I do have some questions
The most pressing Problem seems to be the Encoding. PKCS#7 on purpose employes undefined length BER encoding which is near-impossible to fit onto the current asn.1 implementation (You only learn the length of an object once you have parsed all its (recursive) children.
On a lesser thing: having this be Crypto.IO.PKCS7 sounds fine? How do you actually test Python2.4 support? Do you all have some VM around that has this somewhat dated version opf python installed?