Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow RSA key import without consistency checks #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow RSA key import without consistency checks #33

wants to merge 2 commits into from

Conversation

NathanReb
Copy link

@NathanReb NathanReb commented Sep 21, 2016 •
edited
Loading

It adds a consistency_check argument to PublicKey.RSA.import_key defaulting to True so it doesn't change the default behavior.

@NathanReb
Copy link
Author

I'm not completely happy with the way internal parsers which don't need the passphrase argument deal with it. I gave it a default value so it can pass the test but I'd be happy to change that if you have any suggestion !

@NathanReb
Copy link
Author

I pushed some changes, let me know what you think!

@equal-l2 equal-l2 mentioned this pull request Nov 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanReb