revert using directive to control mock device and port #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also the mock code is of limited usability anyway. I'll probably grab a spare PCM to have a bench setup and a backup sooner or later. |
|
Why would #if MOCKPORT ... #endif need to be removed before submission ? |
|
It wouldnt, but the coresponding define would need to be, either that or the change to the project file to define it globally. Unless I'm missing something? Ive really not done a whole lot of work with preprocessor stuff, and couldnt think of anything else that would be as "automatic" as using the debug symbol. |
antuspcm
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per: 5f47e14#r124815628
I've just reverted this, there isnt really a better way to do this than was there if DEBUG is not usable.
additional #defines (MOCKPORT) would have to be removed before submission anyway, changing the project file to add different symbols or build configs is similar in that they would likely have to be removed before submission as well.