Rewrite buildscript with Unimined and Gradle 8.x #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't alter the group or artifact ID of the main module when publishing locally. Also update the NH maven so it builds.
It was relicensed to standard LGPL at some point
Also consolidate some property expansion
Hooray! Fixed this awful hack
The task already only includes exactly what it needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernizes it, allowing for much easier development and (hopefully) greater resiliency.
Minor changes:
module-xxxtoxxx(not required, I just don't like typingMajor changes:
If I've done my work properly, there shouldn't be any runtime differences to the normal Unimixins jar. As such,
the next version bump would be 0.1.21. Future PRs may make breaking API changes.
Modpacks tested:
Suggest others, if needed