Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezzan9
commented
Nov 30, 2024
Comment on lines
+21
to
22
| const { allUsers, error } = useGetAllUsers(); | ||
|
|
There was a problem hiding this comment.
커스텀 훅을 이용하면 이런식으로 context를 사용하지 않고도 api 응답을 간단하게 가져와서 사용할 수 있어요!
userAPI를 제외하고는 전역적으로 사용되는 api가 없기 때문에,, 그 외 api들은 context를 사용하기보다 이런식으로 수정하는 게 코드의 복잡도를 낮출 수 있을 것 같아요!😊
There was a problem hiding this comment.
현재 context가 많이 사용 되는 걸 어떻게 줄일까 생각했었는데 이렇게 할 수도 있네요! 좋은 방법 같습니다! 다음 이슈에서 적용해 볼게요!
JIN921
approved these changes
Nov 30, 2024
There was a problem hiding this comment.
기존에는 useEffect 내부에서 api 함수를 호출하여 실행했었잖아요 근데 이렇게 따로 뺀 이유가 있을까요? 궁금해서 물어봐용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
#270 을 구현했습니다
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
replaceNewLines분리 (기존에 Utils 파일 안에 있었는데, 각각의 파일로 분리했습니다)ISOtoArrayArrayToISO주석 확인하고 필요한 곳에서 사용하시면 됩니다 !!5. 추가 사항