Feat #77 영수증 수정 기능 추가 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
huncozyboy
reviewed
Nov 25, 2024
|
|
||
| public interface ReceiptUseCase { | ||
| void save(ReceiptDTO.Save dto); | ||
|
|
||
| void update(Long reciptId, ReceiptDTO.Update dto); |
There was a problem hiding this comment.
영수증 아이디 변수명이 reciptId로 되어있는데 의도하신걸까요 아니면 오타일까요 ??
만약 오타가 맞다면 receiptId로 수정해주시는게 좋아보입니당
Comment on lines
41
to
49
| public void update(ReceiptDTO.Update dto){ | ||
| this.updateUpperClass(dto); | ||
| } | ||
|
|
||
| public void updateUpperClass(ReceiptDTO.Update dto) { | ||
| this.description = dto.description(); | ||
| this.amount = dto.amount(); | ||
| this.date = dto.date(); | ||
| } |
There was a problem hiding this comment.
데이터 전달을 ReceiptDTO.Update dto로 객체로 사용해서 분리해준 점이 좋습니다
There was a problem hiding this comment.
updateUpperClass를 따로 분리해서 작성하신 이유가 있을까요?
Receipt는 별도의 상속 관계를 지니지 않아서 굳이 분리할 필요는 없어 보여요!
hyxklee
reviewed
Nov 25, 2024
| @NotNull Integer amount, | ||
| @NotNull LocalDate date, | ||
| @NotNull Integer cardinal, | ||
| @Valid List<FileSaveRequest> files |
There was a problem hiding this comment.
의도하지 않은 null을 막기 위해 @Valid List<@NotNull FileSaveRequest> files로 작성하는 것은 어떨까요?
Comment on lines
41
to
49
| public void update(ReceiptDTO.Update dto){ | ||
| this.updateUpperClass(dto); | ||
| } | ||
|
|
||
| public void updateUpperClass(ReceiptDTO.Update dto) { | ||
| this.description = dto.description(); | ||
| this.amount = dto.amount(); | ||
| this.date = dto.date(); | ||
| } |
There was a problem hiding this comment.
updateUpperClass를 따로 분리해서 작성하신 이유가 있을까요?
Receipt는 별도의 상속 관계를 지니지 않아서 굳이 분리할 필요는 없어 보여요!
hyxklee
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
PR 세부사항
관련 스크린샷
주의사항
체크 리스트