Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#94/계좌 조회,수정 응답형식변경 #96

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

soyesenna
Copy link
Collaborator

📌 관련 이슈

관련 이슈 번호 #94
Close #94

🚀 작업 내용

PR에서 작업한 내용을 설명

  • 계좌 조회, 수정 API 응답 형식을 변경했습니다

📸 스크린샷

📢 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성

@soyesenna soyesenna added the ✨ Feature 기능 개발 및 요구사항 변경 반영 label Feb 4, 2025
@soyesenna soyesenna self-assigned this Feb 4, 2025
Copy link
Member

@hyxklee hyxklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없는 것 같습니다!

@@ -28,15 +29,15 @@ public class AccountController {
public ApiResponse<AccountGetResponse> getAccount(
@CurrentMemberId Long memberId
) {
return ApiResponse.response(OK, ACCOUNT_GET_SUCCESS.getMessage(), AccountGetResponse.of(this.accountService.getAccount(memberId)));
return ApiResponse.response(OK, ACCOUNT_GET_SUCCESS.getMessage(), this.accountService.getAccount(memberId));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

추가된 반환값으로 프론트 분들이 올바른 작업이 가능할거같네용

@soyesenna soyesenna merged commit eea6e02 into dev Feb 4, 2025
2 checks passed
@huncozyboy huncozyboy deleted the feat/#94/계좌-조회,수정-응답형식변경 branch February 6, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 및 요구사항 변경 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: #[94] [계좌 조회, 수정 응답형식 변경]
3 participants