Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 수동매칭 등록 시 시간 String으로 받아 파싱하도록 수정 #93

Conversation

soyesenna
Copy link
Collaborator

📌 관련 이슈

관련 이슈 번호 #88
Close #88

🚀 작업 내용

PR에서 작업한 내용을 설명

  • 수동 매칭 시 출발 시간 String으로 받아서 파싱하도록 수정

📸 스크린샷

📢 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성

@soyesenna soyesenna added the 🔨 Refactor 코드 리팩토링 label Feb 4, 2025
@soyesenna soyesenna self-assigned this Feb 4, 2025
Copy link
Member

@hyxklee hyxklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 포매터 까지 👍🏻

@@ -19,7 +19,7 @@ public record ManualMatchingRequest(
String destinationName,

@NotNull
LocalDateTime departureTime,
String departureTime,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

프론트 요청사항 맞춰서 잘 변경된거같아요

@soyesenna soyesenna merged commit a52a123 into dev Feb 4, 2025
2 checks passed
@huncozyboy huncozyboy deleted the feat/#88수동매칭등록로직시간필드-String으로-변경 branch February 6, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: #[88] [수동 매칭 등록 로직 시간 필드 String으로 변경]
3 participants