refactor: 수동 매칭, 자동 매칭 요청 형식, 타입 통일 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
수동 매칭에는 description, departureTime이 더 있음
hyxklee
reviewed
Feb 5, 2025
| List<Integer> members, | ||
| Integer expectedTotalCharge | ||
| List<Long> members, | ||
| int expectedTotalCharge |
There was a problem hiding this comment.
프론트 측에서 값을 필수로 넣어주나요??
아니면 0이 저장돼서 의도치 않은 흐름이 될 수도 있을 것 같아서
huncozyboy
approved these changes
Feb 5, 2025
hyxklee
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수동 매칭에는 description, departureTime이 더 있음
📌 관련 이슈
관련 이슈 번호 #108
Close #108
🚀 작업 내용
📸 스크린샷
📢 리뷰 요구사항