Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #106 쿠키 도메인 설정하도록 수정 #106

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

hyxklee
Copy link
Member

@hyxklee hyxklee commented Feb 5, 2025

📌 관련 이슈

관련 이슈 번호 #105
Close #105

🚀 작업 내용

  • 프론트 로컬에선 쿠키 발급이 되는데 운영본에서는 안되는 문제가 있어서 domain이 문제인가 싶어서 수정을 해봤습니다.
  • 테스트는 메인에 머지 해야 가능할 것 같습니다
  • 로컬은 환경변수를 "localhost", 개발서버도 "localhost", 운영서버는 "https://gachtaxi.site"로 해줘야할 듯 합니다.

📸 스크린샷

📢 리뷰 요구사항

@hyxklee hyxklee added the 💻 Fix 코드 수정 label Feb 5, 2025
@hyxklee hyxklee self-assigned this Feb 5, 2025
Comment on lines +20 to +22
@Value("${gachtaxi.auth.jwt.cookieDomain}")
private String cookieDomain;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

빠른 테스트가 필요한 PR 내용인거같아, 바로 승인하도록 하겠습니당

Copy link
Collaborator

@soyesenna soyesenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@hyxklee hyxklee merged commit 4eb0e75 into dev Feb 5, 2025
2 checks passed
@hyxklee hyxklee deleted the fix/#105/쿠키-수정 branch February 5, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 Fix 코드 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix]: #105 쿠키 발급 안되는 문제 수정
3 participants