Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #100 친구 API 수정 #100

Merged
merged 11 commits into from
Feb 4, 2025
Merged

Fix #100 친구 API 수정 #100

merged 11 commits into from
Feb 4, 2025

Conversation

koreaioi
Copy link
Member

@koreaioi koreaioi commented Feb 4, 2025

📌 관련 이슈

관련 이슈 번호 #72
Close #72

🚀 작업 내용

PR에서 작업한 내용을 설명

회의를 거치다 보니 수정 사항이 약간 추가됐습니다.

  • FriendsPageableResponse의 필드명을 isLast에서 last로 변경
  • 친구 요청 수락/거절 API 통합
  • 친구 목록 조회 RequestParam 타입 String으로 변경 (프론트측 요청)

📸 스크린샷

📢 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성

@koreaioi koreaioi added the 💻 Fix 코드 수정 label Feb 4, 2025
@koreaioi koreaioi self-assigned this Feb 4, 2025
@koreaioi koreaioi linked an issue Feb 4, 2025 that may be closed by this pull request
1 task
@koreaioi koreaioi changed the title Fix #72 친구 API 수정 Fix #100 친구 API 수정 Feb 4, 2025
Copy link
Member

@hyxklee hyxklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!

Comment on lines +39 to +40
@RequestParam String pageNum,
@RequestParam String pageSize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

해당 부분은 머지돼서 프론트분들 테스트 후, 성공적인 로직으로 작동한다면
다른 무한스크롤 부분도 통일해서 수정하도록 하겠습니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 감사합니다!

@koreaioi koreaioi merged commit bae896f into dev Feb 4, 2025
2 checks passed
@huncozyboy huncozyboy deleted the fix/#71/응답-필드명-변경 branch February 6, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 Fix 코드 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix]: #72 응답 필드명 변경
3 participants