Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-471][Detox] Allure reporting improvements #9287

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Feb 20, 2025

βœ… Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Allure reporting

πŸ“ Description

  • Decouple allure speculos reporting from mocked tests
  • Don't take logs and screenshots for Detox passing tests
  • Fix tms links when several tickets
  • Fix conditionnal app logs and speculos screenshot by adding a global to get test status
  • Put speculos screenshot in allure test body

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Feb 21, 2025 10:24am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 10:24am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 10:24am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 10:24am

@live-github-bot live-github-bot bot added mobile Has changes in LLM automation CI/CD stuff labels Feb 20, 2025
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review February 20, 2025 09:12
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners February 20, 2025 09:12
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_471_allure-improvments branch from 5e1b5cf to c434349 Compare February 20, 2025 11:00
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_471_allure-improvments branch from c434349 to 68291c1 Compare February 21, 2025 08:39
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants