Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error page for LLM #8762

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add error page for LLM #8762

wants to merge 1 commit into from
+17 −7

Conversation

liviuciulinaru
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • navigate to error screen if live app is at /unknown-error

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested a review from a team as a code owner December 24, 2024 15:10
@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 3:11pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 3:11pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 3:11pm
web-tools ⬜️ Ignored (Inspect) Dec 24, 2024 3:11pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpaquet-ledger lpaquet-ledger lpaquet-ledger approved these changes

Assignees

@liviuciulinaru liviuciulinaru

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviuciulinaru @lpaquet-ledger