Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swap feature to Solana application #44

Merged
merged 13 commits into from
Apr 18, 2023

Conversation

fbeutin-ledger
Copy link

No description provided.

@fbeutin-ledger
Copy link
Author

Continuation of #41

doc/api.md Outdated Show resolved Hide resolved
src/signMessage.c Outdated Show resolved Hide resolved
src/main.c Show resolved Hide resolved
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch from 30c41f5 to f131fe4 Compare October 13, 2022 08:05
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/solana_code_improvements_post_refacto branch from 3d50d69 to d7b0615 Compare October 17, 2022 08:14
lpascal-ledger
lpascal-ledger previously approved these changes Oct 24, 2022
Base automatically changed from wip/fbeutin/solana_code_improvements_post_refacto to develop October 27, 2022 13:49
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch from b496de4 to 0918d87 Compare October 27, 2022 13:53
@askibin
Copy link

askibin commented Nov 15, 2022

@fbeutin-ledger is it possible to combine this with #45 (i.e. to merge #45 into your branch) and rebase the result against develop? this way I'll see how final changes will look like.

@fbeutin-ledger
Copy link
Author

Hello @askibin
I have an issue currently with the swap feature using too much RAM, I'm trying to fix it but in the meantime I would like to freeze the swap branch so the changes are localized

@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch 5 times, most recently from b0ef2e2 to 5d1d63f Compare January 25, 2023 12:40
@fbeutin-ledger fbeutin-ledger changed the base branch from develop to fbe/use_ocr_for_tests January 25, 2023 12:40
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch from 5d1d63f to 3893329 Compare January 25, 2023 12:47
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch 3 times, most recently from 966af8f to 0808068 Compare February 1, 2023 19:10
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch from 0808068 to 56273e5 Compare February 1, 2023 19:20
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch from f25ae53 to 04d0ad3 Compare February 1, 2023 19:29
lpascal-ledger
lpascal-ledger previously approved these changes Feb 2, 2023
src/main.c Show resolved Hide resolved
src/signMessage.c Outdated Show resolved Hide resolved
src/signMessage.c Outdated Show resolved Hide resolved
Base automatically changed from fbe/use_ocr_for_tests to develop February 2, 2023 14:20
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch from a4ace5c to c1d4da6 Compare February 3, 2023 10:46
@fbeutin-ledger fbeutin-ledger force-pushed the wip/fbeutin/swap_rebase_post_refacto branch from 8070f5f to e79f36d Compare February 7, 2023 14:42
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fbeutin-ledger fbeutin-ledger merged commit f7e9932 into develop Apr 18, 2023
@fbeutin-ledger fbeutin-ledger deleted the wip/fbeutin/swap_rebase_post_refacto branch April 18, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants