Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clang formatting #34

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Apply clang formatting #34

merged 1 commit into from
Aug 2, 2022

Conversation

fbeutin-ledger
Copy link

@fbeutin-ledger fbeutin-ledger commented Jul 29, 2022 •
edited
Loading

File bin/app.sha256 before and after clang formatting is identical

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

82.0% 82.0% Coverage
72.1% 72.1% Duplication

@fbeutin-ledger
Copy link
Author

The SonarCloud CI failing for duplicated code has a workaround in this PR
#32
And is thus outside of the scope of this PR

@fbeutin-ledger fbeutin-ledger mentioned this pull request Jul 29, 2022
Merged
@t-nelson
Copy link

is this really necessary?

@fbeutin-ledger fbeutin-ledger merged commit 5385d52 into develop Aug 2, 2022
@fbeutin-ledger fbeutin-ledger deleted the wip/fbeutin/apply_clang_formatting branch August 2, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaillier-ledger apaillier-ledger apaillier-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbeutin-ledger @t-nelson @apaillier-ledger