Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic updates #49

Merged
merged 10 commits into from
Dec 17, 2024
Merged

cosmetic updates #49

merged 10 commits into from
Dec 17, 2024

Conversation

pangratt12345
Copy link
Contributor

hi,
thank you for this great application.
I made some cosmetic updates, if you have time then you can revise these updates
added state retention (android:configChanges="orientation|screenSize") so that context and state are not destroyed and recreated during screen rotations. This enables rotating into landscape mode in login screen when trying to type using landscape keyboard mode. Maybe this isn't a good idea, it's up to you.
added more instructions to readme for installation of rust for easier installation using Android Studio
updated settings screen so that whole dropdown menu box is clickable and Poll Interval text is centered, more seconds and minutes options
added error show dialog if service didn't start correctly as mentioned in todo
added some validation of email and password to avoid error exceptions when empty password or bad email is typed

@LeanderBB
Copy link
Owner

LeanderBB commented Nov 29, 2024 via email

@pangratt12345
Copy link
Contributor Author

hi, of course, there is no haste with this

Copy link
Owner

@LeanderBB LeanderBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall everything looks good. Thank you for these fixes and improvements.

There are just a small couple of things that should be corrected.

@LeanderBB
Copy link
Owner

Finally could you prefix your commit titles with one of the following:

  • chore: commit title
  • fix: commit title
  • refactor: commit title
  • feat: commit title

@pangratt12345
Copy link
Contributor Author

hi,
ok, thank You for looking into this. I changed the code accordingly to all your suggestions. I resetted all commits and committed back with clear names accordingly to convention that you use (I don't know to rename old commits, sorry) so pull request got automatically closed and reopened

@pangratt12345 pangratt12345 reopened this Dec 11, 2024
@LeanderBB
Copy link
Owner

Thanks for the update. Just one last thing with the drop down menu in the settings and we can merge this in :)

@pangratt12345
Copy link
Contributor Author

ok, I added new commit now for Settings.kt which reverted all colors to original ones from your last commit + tweak to DropDownMenu width so that it has identical width as TextField it drops down from

@pangratt12345 pangratt12345 force-pushed the main branch 2 times, most recently from 9a71bf9 to f3c389f Compare December 15, 2024 19:19
@pangratt12345
Copy link
Contributor Author

ok :) I changed last commit now and all colors should be now reverted and identical as in your last commit including the text color in TextField

@LeanderBB LeanderBB merged commit ac7cbca into LeanderBB:main Dec 17, 2024
3 checks passed
@pangratt12345
Copy link
Contributor Author

cool, if you have some other tasks for me, then you can always tell me, merry christmas :)

@LeanderBB
Copy link
Owner

Will do, Merry Christmas to you as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants