-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmetic updates #49
cosmetic updates #49
Conversation
Hey, thanks for taking the time to add these improvements.
I am currently a bit busy with some personal stuff. I will try to look into this as soon as I am able.
|
hi, of course, there is no haste with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall everything looks good. Thank you for these fixes and improvements.
There are just a small couple of things that should be corrected.
you-have-mail-android/app/src/main/java/dev/lbeernaert/youhavemail/screens/Settings.kt
Outdated
Show resolved
Hide resolved
you-have-mail-android/app/src/main/java/dev/lbeernaert/youhavemail/MainActivity.kt
Show resolved
Hide resolved
Finally could you prefix your commit titles with one of the following:
|
…ndings or cargoBuild
… + cosmetic changes
hi, |
Thanks for the update. Just one last thing with the drop down menu in the settings and we can merge this in :) |
ok, I added new commit now for Settings.kt which reverted all colors to original ones from your last commit + tweak to DropDownMenu width so that it has identical width as TextField it drops down from |
9a71bf9
to
f3c389f
Compare
ok :) I changed last commit now and all colors should be now reverted and identical as in your last commit including the text color in TextField |
cool, if you have some other tasks for me, then you can always tell me, merry christmas :) |
Will do, Merry Christmas to you as well! |
hi,
thank you for this great application.
I made some cosmetic updates, if you have time then you can revise these updates
added state retention (android:configChanges="orientation|screenSize") so that context and state are not destroyed and recreated during screen rotations. This enables rotating into landscape mode in login screen when trying to type using landscape keyboard mode. Maybe this isn't a good idea, it's up to you.
added more instructions to readme for installation of rust for easier installation using Android Studio
updated settings screen so that whole dropdown menu box is clickable and Poll Interval text is centered, more seconds and minutes options
added error show dialog if service didn't start correctly as mentioned in todo
added some validation of email and password to avoid error exceptions when empty password or bad email is typed