Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PC flattening, autoflatten on levelup, flatten options #15

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

shun17
Copy link
Contributor

@shun17 shun17 commented Jun 17, 2024

Hi, I made some modifications vor v11 months ago, but I wasn't able to submit a pull request.

I made some modifications to enhance the NPCs and PCs flattening, using the same sulf for all bonuses to prevent problem during flatten/unlfatten, using also the official sulggifier of pf2e system. I also made selectable the rounding mode and added button for flatten/unflatten all actors.

I saw that the functionality for PCs was removed, but I used it a lot in my campagin, so still worth workin on it for me, so I'm suibmitting the pull request with the functionality restored.

If something is wrong or need some clarification feel free to reach me, thanks a lot for the add-on

@velara
Copy link
Collaborator

velara commented Jun 17, 2024

I'm going to have to spend some time thinking about whether I want to implement this as is or pull some stuff out of it and integrate it in a fashion that's more in line with how I tend to code. There's some features you've implemented that I think are definitely worth adding. But there's several sections that are fairly different from the approach I would take, which means they're harder for me to maintain.

@shun17
Copy link
Contributor Author

shun17 commented Jun 17, 2024

I tried to generalize the code splitting it in "logic section" based on the context:

  • the first section for the configuration and the user configuration options
  • the registration on init for the gm screen of the various buttons
  • all the event hooks logic
  • the actual flattening logic for who and how to flatten

Let me know if you need some rework or anything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants