Do not use percentage for width on an SVG object element#153
Open
xfq wants to merge 1 commit intoLeaVerou:gh-pagesfrom
Open
Do not use percentage for width on an SVG object element#153xfq wants to merge 1 commit intoLeaVerou:gh-pagesfrom
width on an SVG object element#153xfq wants to merge 1 commit intoLeaVerou:gh-pagesfrom
Conversation
`width`/`height` on `object` only accepts CSS pixels: https://html.spec.whatwg.org/multipage/embedded-content-other.html#dimension-attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
width/heightonobjectonly accepts CSS pixels. This patch removes thewidthattribute, because it doesn't seem to be needed.(This commit also removes the trailing whitespace in
index.html. You can add?w=1to the URL to see the diff with whitespace ignored. Thank you!)