-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a node creation helper, initialized by 'initNodeCreationHelper'… #9
base: master
Are you sure you want to change the base?
Conversation
…, can be reached by hitting the tab key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this shouldn't be part of Nodz but an add on.
(Why ?)
Because people might not want to use tab for this purpose by default.
2 Signals (Tab and Esc key press events) are the only things that should be added to Nodz. Then everybody is free to connect them (to sanything they want) or not.
Let me know if you want to discuss it more
Sounds fine to me. |
To me, it is an "extra tool" that can be used for a lot of things other than it's implementation for Nodz, so it shouldn't live inside Nodz. I see that more as an optional dependency (Basically everything not directly Nodz related is an optional dependency) but I don't want users to be freaked out by the amount of dependencies contained in my Nodz repository (If we come up with more of them) So I still think that signals only is the way to go then under README we can add an "optional dependencies" section with links to them (They would live in your own repositories) so users don't get overwhelmed by all these extra/optional features and can decide ta add them or not. Regarding the signals, I think there is already a signal that is triggered when a key is pressed and return the key, maybe we can do something with that. |
Ok, It's agreed that this tool should not be part of the nodz_main. So for it to benefit other users, I renamed the python .py file (nodz-extra) into nodz_addon. You can use nodz_main without it, or you can just use it if you need the things that are inside. How does it sounds like this ? |
…tsWithMultipleConnections Fix node deletion not removing all connections if multiple conneciton…
Added a node creation helper, that you reach by hitting the tab key (Maya node editor style)
Updated the readme and nodz_demo to demonstrate usage.
I didn't want to add too much things in the main python file, so I ended up added an nodz_extra.py file for the main part of the UI, and only minor adds in the nodz_main.py.
Just let me know if you wish it done another way.