-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refuse to migrate from top into non-top documents #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizman
changed the title
make sure lavadome refuses to load within non top documents
Refuse to load LavaDome within non-top documents
Jun 2, 2024
weizman
changed the title
Refuse to load LavaDome within non-top documents
Refuse to migrate a LavaDome instance from top into non-top documents
Jun 23, 2024
legobeat
reviewed
Sep 10, 2024
legobeat
reviewed
Sep 10, 2024
Co-authored-by: legobeat <[email protected]>
weizman
force-pushed
the
main
branch
2 times, most recently
from
September 18, 2024 08:04
7958a69
to
fa4643f
Compare
weizman
changed the title
Refuse to migrate a LavaDome instance from top into non-top documents
Refuse to migrate from top into non-top documents
Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context @ #35
poc following @masatokinugawa finding #35 (comment) for making sure lavadome instances refuse to load within iframes so they can't be attacked
(consider adding a warning)