New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta function argument phpdoc #705

Open

edgarsn wants to merge 1 commit into LaravelCollective:6.x from edgarsn:meta-function-argument-type-fix

edgarsn commented Feb 9, 2022

Currently Html::meta() only accepts string $name in phpdoc, but it can be null as well. For open graph name is not required attribute.

Usage sample: Html::meta(null, 'This is description', ['property' => 'og:description'])

This will fix phpstan & ide errors/warnings when using null.

Also I updated attributeElement phpdoc types for arguments, since it's used by meta function.


          function argument types fixed

f77439f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet