forked from woowacourse/java-lotto
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[로또 게임] 임주민 과제 제출합니다. #9
Open
jumining
wants to merge
32
commits into
LandvibeDev:main
Choose a base branch
from
jumining:jumining
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
늦은 제출이라 염치없지만 리뷰해주시면 정말로 감사하겠습니다! 죄송합니다
예외 테스트가 통과가 안되는데 예외 처리가 부족해서인지 아직 이유를 모르겠습니다. 더 탐구해보도록 하겠습니다!
객체지향적으로 코드를 짜보려고 노력중이나 인터페이스 사용과 같은 부분은 아직 부족하고 그냥 쪼개기만 한 제 코드가 절차지향적인 것 같기도 합니다.. 코드를 작성하면서도 이게 구조상 좋은 코드인지 비효율적인지 긴가민가 한 것이 많습니다..! 저번 과제 멘토님의 코드를 보면서 참고하면서 공부 중이나, 제 코드에 대해 날카로운 리뷰 부탁드립니다! 과제 제출 후 주어진 책들을 읽어보면서 공부하고 리팩토링을 해야할 것 같습니다.