[로또 게임] 김동하 과제 제출합니다 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion when input char type
sunwootest
requested changes
Jul 8, 2023
Comment on lines
+3
to
+12
| public class CheckCharException { | ||
| public void checkCharException(String input){ | ||
| for(int i = 0; i < input.length(); i++){ | ||
| if(input.charAt(i) >= '0' && input.charAt(i) <= '9'){ | ||
| continue; | ||
| } | ||
| throw new IllegalArgumentException("[ERROR]숫자만 입력하세요."); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
예외라는 것을 표현해주기 위해서는 특정 Exception을 상속해주는 것이 나아보입니다.
IllegalArgumentException을 상속받고 해당 예외처리 할 때 IllegalArgumentException으로 예외전환 해주는 것은 어떤가요?
Comment on lines
+15
to
+17
| public LottoGame(){ | ||
|
|
||
| } |
Comment on lines
+10
to
+14
| public BuyMoney(){ | ||
| System.out.println("구입 금액을 입력해 주세요."); | ||
| inputBuyMoney = Console.readLine(); | ||
| CheckCharException checkCharException = new CheckCharException(); | ||
| checkCharException.checkCharException(inputBuyMoney); |
There was a problem hiding this comment.
예외처리 방법이 부자연스럽습니다. 외부의 검증 클래스를 사용하려면 필드로 선언하는 편이 자연스러워 보이네요. 클래스명에 Exception을 사용하면 예외의 종류로 오해할 수 있어 보입니다.
Comment on lines
+16
to
+18
| if(buyMoney % 1000 != 0){ | ||
| throw new IllegalArgumentException("[ERROR]1000원 단위로 입력해 주세요."); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.