docs: use the fully-qualified brew install name, not the bare one - #13
Merged
Merged
Conversation
The documented Homebrew flow (`brew tap ...` then `brew install rook`) hits Homebrew's tap-trust gate: `Error: Refusing to load formula lambdatest/rook/rook from untrusted tap lambdatest/rook.` Reported live by a user following these exact instructions verbatim; reproduced byte-for-byte on a fresh tap. Root cause: Homebrew requires third-party-tap formulae to be trusted before loading (default-on, `trust.rb`), except when installed by the fully-qualified `user/tap/formula` name, which its own `explicitly_allowed?` check treats as sufficient explicit consent — confirmed directly in Homebrew's source. brew-smoke.yml has always installed by the fully-qualified name (`brew install lambdatest/rook/rook`), which is exactly why CI never caught this — only the README's bare `brew install rook` form is affected. CHANGELOG.md already had the correct form. Verified live: `brew install rook` after the tap fails with the exact reported error; `brew install lambdatest/rook/rook` on the same tap succeeds with no trust prompt at all. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported live by a user following these exact instructions verbatim:
Root cause
Homebrew requires third-party-tap formulae to be trusted before loading
(default-on since a recent Homebrew version,
trust.rb) — except wheninstalled by the fully-qualified
user/tap/formulaname, which Homebrew'sown
explicitly_allowed?check treats as sufficient explicit consent(confirmed directly in Homebrew's source: it checks whether the qualified
name appears literally in the invoking command's own args).
brew-smoke.ymlhas always installed by the fully-qualified name(
brew install lambdatest/rook/rook) — exactly why CI never caught this.The README documented the bare form (
brew install rook, after a separatebrew tap), which doesn't satisfy that check.CHANGELOG.mdalready hadthe correct fully-qualified form.
Verified live
brew tap LambdaTest/rook ...thenbrew install rookon a fresh tap:reproduces the exact reported error.
brew tap LambdaTest/rook ...thenbrew install lambdatest/rook/rookon the same tap: succeeds, no trust prompt.
Agent-authored: Claude Sonnet 5, Claude Code CLI.