fix: flip brew-smoke's node dependency-scope guard to match #11 - #12
Merged
Conversation
#11's PR body said this guard would flip back to asserting node is NOT a required dependency, now that def install writes its own self-contained launcher. That edit never actually happened — the guard still asserted the opposite (PR #10's invariant), so the very first brew-smoke run against the rebuilt bottle failed at this step before ever reaching Install rook / brew test. Confirmed this is the only thing broken: build-bottles.yml's own "Build bottle" step (the real `brew install --build-bottle`, running def install's new code) already passed cleanly on both platforms in the run that published the current bottle. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #11's own body said this guard would flip back to asserting node is NOT a required dependency. That edit never actually landed — caught it live: the first brew-smoke run against the rebuilt bottle (https://github.com/LambdaTest/rook/actions/runs/32035776875) failed at this guard before ever reaching
Install rook/brew test. Not a regression in #11's actual fix —build-bottles.yml's ownBuild bottlestep (the realbrew install --build-bottle, runningdef install's new launcher-writing code) already passed on both platforms in the run that published the current bottle. Re-dispatchingbrew-smokeonce this merges for the real end-to-end confirmation.actionlint clean, YAML parses.
Agent-authored: Claude Sonnet 5, Claude Code CLI.