LibWeb/HTML: Implement some navigation spec updates #6955
+154
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used from a few different places in the spec.
I missed where this change happened in the spec. The second half of abort_the_ongoing_navigation() becomes a separate method, which is slightly rearranged. I've placed this in Navigation instead of NavigateEvent because of how many steps poke at the Navigation's internals. The text here includes the amendments I made in whatwg/html#11967 to correct a variable name. A bonus is that we now actually populate the ErrorEvent instead of leaving it blank.
Corresponds to: whatwg/html@93634ae The current live spec has been rearranged since this went in, so that these steps are no longer located here. But that's a much larger change that I don't want to implement right now. See here: whatwg/html@e09d102 While I was at it, I also made use of extract_error_information() to populate the ErrorEvent.
AtkinsSJ
force-pushed
the
navigation-spec-changes
branch
from
0f80d9d to
59a0205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.