LibWeb: Apply clip frames even when transformation is identity #6940
+54
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradekk
reviewed
Nov 26, 2025
Clip frames for overflow were applied based on whether the box in question had a non-identity matrix transformation associated with it. That however is not correct, since specifying a no-op transform like `scale(1)` still needs to apply clip overflow rectangles. So instead we need to check whether the element associated with the box in question has any CSS transforms. This appears to have been a regression from 9bbc1cd and effectively reverts that commit, but keeps its effect by unifying on the check for CSS transforms instead. This fixes some background boxes being rendered for the invisible items of the carousels on https://computerbase.de/.
InvalidUsernameException
force-pushed
the
missing-background-clip
branch
from
df75467 to
19cf349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clip frames for overflow were applied based on whether the box in question had a non-identity matrix transformation associated with it. That however is not correct, since specifying a no-op transform like
scale(1)still needs to apply clip overflow rectangles. So instead we need to check whether the element associated with the box in question has any CSS transforms.This appears to have been a regression from 9bbc1cd (#6285) and effectively reverts that commit, but keeps its effect by unifying on the check for CSS transforms instead.
This fixes some background boxes being rendered for the invisible items of the carousels on https://computerbase.de/.
Before:
After:
/cc @kalenikaliaksandr