LibWeb: Parse the scroll driven animation CSS properties #6912
+2,312
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids a crash when `animation-duration` was `auto`
The remaining failing tests in scroll-timeline-shorthand.html are due to either: a) incorrect tests, see web-platform-tests/wpt#56181 or; b) a wider issue where we collapse coordinating value list longhand properties to a single value when we shouldn't.
The remaining failing tests in view-timeline-shorthand.html are due to either: a) incorrect tests, see web-platform-tests/wpt#56181 or; b) a wider issue where we collapse coordinating value list longhand properties to a single value when we shouldn't.
Required for `animation-timeline` and the various `animation-trigger-*` properties within the `animation` coordinating value list
Calme1709
force-pushed
the
scroll-animations-properties
branch
from
db51aa5 to
925bb54
Compare
Contributor
Author
|
Changes: |
AtkinsSJ
requested changes
Nov 28, 2025
Member
AtkinsSJ
left a comment
AtkinsSJ
left a comment
There was a problem hiding this comment.
Very cool! I wasn't expecting this any time soon. Just a couple of very minor things.
(It also bothers me every time reset-only longhands still have to be done manually, or coordinating value lists, or parsing a list not always returning a list. I'll have to see if I can revive my branch for the former. 😅)
| auto stringified_inset = inset_values[i]->to_string(mode); | ||
|
|
||
| if (stringified_inset != "auto"sv) | ||
| builder.appendff(" {}", inset_values[i]->to_string(mode)); |
Member
There was a problem hiding this comment.
You can use stringified_inset here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step towards implementing CSS scroll driven animations.
Some of the imported tests continue to fail due to the fact that we serialize coordinating value list longhands (e.g. scroll-timeline-axis, animation-duration, etc) incorrectly in that if all values are the same we serialize them as a single value.
Gains us ~320 WPT tests.