LibDNS: Remove usage of await #6901
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lubrsi
force-pushed
the
remove-await-from-libdns
branch
from
26dd7b4 to
dd30452
Compare
alimpfard
reviewed
Nov 21, 2025
Contributor
alimpfard
left a comment
alimpfard
left a comment
There was a problem hiding this comment.
This is a lot of moving stuff around, but nothing weird sticks out so 🤷 refactor LGTM at least.
konradekk
reviewed
Nov 22, 2025
Contributor
konradekk
left a comment
konradekk
left a comment
There was a problem hiding this comment.
did not read the contents carefully; just nitpicking (as usual from me).
| }; | ||
|
|
||
| TRY_OR_FAIL(resolver.when_socket_ready()->await()); | ||
| auto when_socket_ready_promise = resolver.when_socket_ready(); |
Contributor
There was a problem hiding this comment.
socket_ready/socket_readiness or socket_is_ready? (when_ is the resolution part; _promise is unnecessary in typed environment? same for names below?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the process of removing event loop spinning from the codebase.