Rick and Morty filter page. #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow info into javascript to html and an eventlistener to use a button that show another page for choose seasons
Pleaseenter the commit message for your changes. Lines starting
werge branch 'develop' of https://github.com/Dianax69/CDMX009-Data-Lovers into develop
AdrianaHY
reviewed
Mar 29, 2020
| export const example = () => { | ||
| return 'example'; | ||
| }; | ||
| export const sum = (a, b) => a + b; |
There was a problem hiding this comment.
Para que utilizas esta función?
AdrianaHY
reviewed
Mar 29, 2020
| <meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| <link rel="stylesheet" href="style.css"/> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Bubblegum+Sans"> | ||
| </head> |
There was a problem hiding this comment.
Hay que ser consistentes con los espacios.
AdrianaHY
reviewed
Mar 29, 2020
| </header> | ||
| <div> | ||
| <button class="button_characters" id="button-random-char">Personajes Aleatorios</button> | ||
| </div> |
AdrianaHY
reviewed
Mar 29, 2020
| <div id="container-cards"></div> | ||
| </section> | ||
| <!-- Mobile menu --> | ||
| <div id="mobile-menu" style="display: none;"> |
There was a problem hiding this comment.
El comentario no es necesario ya que la clase es suficientemente descriptiva.
AdrianaHY
reviewed
Mar 29, 2020
| /* | ||
| function to generate a filter object with params | ||
| Prams: (Original object, key to filter, value to match with key) | ||
| */ |
There was a problem hiding this comment.
Recuerda borrar el código que no se utiliza y los console.log
AdrianaHY
reviewed
Mar 29, 2020
| } | ||
| }); | ||
| // Filter for Gender | ||
| document.querySelector('#buttonGroupGender').addEventListener('click', (e) => { |
AdrianaHY
reviewed
Mar 29, 2020
| } | ||
| }); | ||
| // Filter for Status | ||
| const filterAlive = objectRMData.filter((item) => item.status === 'Alive'); |
AdrianaHY
reviewed
Mar 29, 2020
| buttonAlive.addEventListener('click', () => { | ||
| makeCard(filterAlive); | ||
| }); | ||
| const filterDead = objectRMData.filter((item) => item.status === 'Dead'); |
There was a problem hiding this comment.
Procura que los espacios sean consistentes.
AdrianaHY
reviewed
Mar 29, 2020
| } | ||
| #wrapper_data { | ||
| margin-top: auto; | ||
| } |
There was a problem hiding this comment.
Felicidades por el uso de media queries!
AdrianaHY
reviewed
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Lovers sobre Rick and Morty, "Wubba Lubba Dub Dub" sirve para filtrar y mostrar información sobre los personajes de las tres temporadas de la serie.