Not setting shape and dtype in config window when no image acquired #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the shape and dtype of the error image were being saved. This behavior was leading to an unclear bug for the user.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Camera Configuration window (
CameraConfig), the shape and data type of the last acquired image is saved. It is then passed to the parentCameraBlock, for initializing internal data structures. When no image can be grabbed, an information image is displayed in the configuration window. However, until now, the shape and dtype of this information image was being saved and passed to theCameraBlock. This was causing cryptic bugs for users.With this PR, the shape and dtype is never saved when the information image is displayed. If no real image can be acquired before exiting the configuration window, an error signaling that the shape and dtype are missing is raised and stops the test.