Mod: Re-activate pytests, exclude SPICE computation tests on windows …

…workflow.
Labbeti · Sep 25, 2023 · df12588 · df12588
1 parent da3f8e8
commit df12588
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 17 deletions.
diff --git a/src/aac_metrics/download.py b/src/aac_metrics/download.py
@@ -260,13 +260,6 @@ def _download_spice(
             with ZipFile(fpath, "r") as file:
                 file.extractall(parent_tgt_dpath)
 
-    # TODO: rm
-    # mv $SPICELIB/$CORENLP/stanford-corenlp-3.6.0.jar $SPICELIB/
-    # mv $SPICELIB/$CORENLP/stanford-corenlp-3.6.0-models.jar $SPICELIB/
-    # dpath_unzip="$dpath_spice/SPICE-1.0"
-    # mv "$dpath_unzip/lib" "$dpath_spice"
-    # mv "$dpath_unzip/spice-1.0.jar" "$dpath_spice"
-
     spice_lib_dpath = osp.join(spice_cache_dpath, "lib")
     spice_unzip_dpath = osp.join(spice_cache_dpath, "SPICE-1.0")
     corenlp_dname = "stanford-corenlp-full-2015-12-09"
@@ -301,10 +294,6 @@ def _download_spice(
             pylog.info(f"Moving '{src_path}' to '{parent_tgt_dpath}'...")
             shutil.move(src_path, parent_tgt_dpath)
 
-    # TODO: rm
-    # rm -f stanford-corenlp-full-2015-12-09.zip
-    # rm -rf $SPICELIB/$CORENLP/
-
     shutil.rmtree(corenlp_dpath)
     if clean_archives:
         spice_zip_fname = DATA_URLS["spice_zip"]["fname"]

diff --git a/tests/ign_test_bleu_tchmet.py → tests/test_bleu_tchmet.py b/tests/ign_test_bleu_tchmet.py → tests/test_bleu_tchmet.py
diff --git a/tests/ign_test_compare_cet.py → tests/test_compare_cet.py b/tests/ign_test_compare_cet.py → tests/test_compare_cet.py
@@ -106,7 +106,6 @@ def _get_example_0(self) -> tuple[list[str], list[list[str]]]:
 
     def _test_with_example(self, cands: list[str], mrefs: list[list[str]]) -> None:
         if platform.system() == "Windows":
-            # Skip this setup on windows
             return None
 
         corpus_scores, _ = evaluate(cands, mrefs, metrics="dcase2020")

diff --git a/tests/ign_test_compare_fense.py → tests/test_compare_fense.py b/tests/ign_test_compare_fense.py → tests/test_compare_fense.py
diff --git a/tests/test_doc_examples.py b/tests/test_doc_examples.py
@@ -18,10 +18,8 @@
 
 class TestReadmeExamples(TestCase):
     def test_example_1(self) -> None:
-        # TODO : rm or redo ?
-        # if platform.system() == "Windows":
-        #     # Skip this setup on windows
-        #     return None
+        if platform.system() == "Windows":
+            return None
 
         candidates: list[str] = ["a man is speaking", "rain falls"]
         mult_references: list[list[str]] = [
@@ -61,7 +59,6 @@ def test_example_1(self) -> None:
 
     def test_example_2(self) -> None:
         if platform.system() == "Windows":
-            # Skip this setup on windows
             return None
 
         candidates: list[str] = ["a man is speaking", "rain falls"]