Skip to content

Commit

Permalink
Fix: Java version check with packaging lib.
Browse files Browse the repository at this point in the history
  • Loading branch information
Labbeti committed Feb 15, 2024
1 parent 8d6ae51 commit dd70e49
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/aac_metrics/utils/checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ def _check_java_version(version_str: str, min_major: int, max_major: int) -> boo

if version.major == 1 and version.minor <= 8:
# java <= 8 use versioning "1.MAJOR.MINOR" and > 8 use "MAJOR.MINOR.MICRO"
version.major = version.minor
version.minor = version.micro
version.micro = 0 # unknown micro, but it does not matter here
version_str = ".".join(map(str, (version.major, version.micro)))
version = Version(version_str)

return Version(f"{min_major}") <= version < Version(f"{max_major + 1}")

0 comments on commit dd70e49

Please sign in to comment.