Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve snaugment #243

Merged
merged 13 commits into from
Jun 18, 2021
Merged

Improve snaugment #243

merged 13 commits into from
Jun 18, 2021

Conversation

Catarina-Alves
Copy link
Collaborator

Further improvements on snaugment.

@Catarina-Alves Catarina-Alves added enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. pre-v2.0.0 Issues that should be completed prior to public release of v2.0.0 labels Apr 17, 2021
@Catarina-Alves Catarina-Alves marked this pull request as ready for review April 17, 2021 19:48
@tallamjr
Copy link
Collaborator

Further improvements on snaugment.

Could you comment a bit on what are the key changes.

Is the main idea this PR brings is removal of class NNAugment(SNAugment): along with syntax tidy up?

@Catarina-Alves
Copy link
Collaborator Author

Further improvements on snaugment.

Could you comment a bit on what are the key changes.

Is the main idea this PR brings is removal of class NNAugment(SNAugment): along with syntax tidy up?

@tallamjr, It is basically the removal of class NNAugment(SNAugment), and splitting the augmentation on WFD and DDF augmentation. These are now two child classes of GPAugment.

@Catarina-Alves Catarina-Alves mentioned this pull request Apr 21, 2021
Merged
MichelleLochner
MichelleLochner reviewed Jun 10, 2021
View reviewed changes
snmachine/snaugment.py Outdated Show resolved Hide resolved
utils/future_augment.py Outdated Show resolved Hide resolved
@MichelleLochner MichelleLochner merged commit b77241d into dev Jun 18, 2021
@Catarina-Alves Catarina-Alves deleted the improve-snaugment branch June 18, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleLochner MichelleLochner MichelleLochner left review comments

@tallamjr tallamjr Awaiting requested review from tallamjr

Assignees
No one assigned
Labels
enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. pre-v2.0.0 Issues that should be completed prior to public release of v2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Catarina-Alves @tallamjr @MichelleLochner