Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/227/include license #228

Merged
merged 12 commits into from
Mar 24, 2021
Merged

Issue/227/include license #228

merged 12 commits into from
Mar 24, 2021

Conversation

Catarina-Alves
Copy link
Collaborator

Solves #227. I added the authors the same way @MichelleLochner did in 2018.
Do you prefer different wording?

Regarding the date, I followed the Guidelines for DESC Repositories (download from here) refers

Conventionally, copyright statements list the year a work is originally created, and any year where substantial changes (e.g. new versions or releases) are made.
Besides 2016, I included 2021 because we are planning to release a new version.

@Catarina-Alves Catarina-Alves added pre-v2.0.0 Issues that should be completed prior to public release of v2.0.0 documentation Updates to documentation required labels Mar 10, 2021
@Catarina-Alves
Copy link
Collaborator Author

@MichelleLochner, when you have time, can you take a look at this?

Basically, I added a license, so see if you like it or want to change it/ its wording.
Additionally, I added a few lines to resolve deprecation problems (does not change the code, sklearn simply changed some internal names).

Importantly, I commented out some failing tests in snfeatures. These tests were close to failing when we looked at them some time ago. At the time we thought this had to do with sncosmo updates. If this PR is accepted I will add test_templates_leastsq and test_newling_leastsq to the list of tests to be fixed in #221.

@MichelleLochner MichelleLochner merged commit 1094aea into dev Mar 24, 2021
@Catarina-Alves Catarina-Alves deleted the issue/227/include-license branch March 24, 2021 10:29
@Catarina-Alves Catarina-Alves mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates to documentation required pre-v2.0.0 Issues that should be completed prior to public release of v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants