Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/5/create basic lephareestimator class #9

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

raphaelshirley
Copy link
Collaborator

@raphaelshirley raphaelshirley commented Mar 27, 2024

Made a basic Estimator class that runs through the goldenspike example

This relates to issue 5.

I plan to merge this basic running example before moving on to improving and tidying various aspects including the parameter changes planned. I will add a basic unit test running the inform and estimate stage as another PR.

The example notebook has a link to a local repository required to get the filters and sed templates that are not yet incorporated into lephare.

It is unclear why I cannot produce a redshift density plot but only see the histograms.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Raphael Shirley added 2 commits March 26, 2024 22:50
zmode doesnt seem to be added to output.
Still questions over what stages should go in the inform or estimate stage
Still issues with params. Performance seems comparable to BPZ. Added example notebook.
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. I'm sure there will be bugs, but let's push ahead. :)

@drewoldag drewoldag merged commit 7760d56 into main Apr 5, 2024
2 of 5 checks passed
@drewoldag drewoldag deleted the issue/5/create-basic-lephareestimator-class branch April 5, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants