LephareInformer passing basic tests in goldenspike notebook #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2024 16:50
Working through the goldenspike notebook one step at a time
We are overwriting config from the para file via python possibly unnecesarily Can we confirm config settings for LSST
drewoldag
reviewed
Mar 26, 2024
| extinc_law="SB_calzetti.dat", | ||
| ) | ||
| maglib.run( | ||
| typ="GAL", |
There was a problem hiding this comment.
We were talking about this earlier, but yes, either these can be StageParam values that are passed in, or alternatively, we could pass this in as a single config dictionary StageParam.
It kind of depends on how this will be run.
- Would it be typical to run three in a row like this, or would this ultimately just call
mag.libone time per stage? - Are there many variables beyond the ones that are listed? Will there be more? If yes to either, then perhaps dictionary makes more sense so that a change in input variables in LePhare doesn't require a change in StageParams in
rail_lephare.
drewoldag
reviewed
Mar 26, 2024
|
|
||
| # Give principle inform config 'model' to instance. | ||
| self.model = dict(config_file=self.config_file) | ||
| self.add_data("model", self.model) |
There was a problem hiding this comment.
Is this what BPZ is doing? I'm not criticizing it, just curious. Ceci likes there to be some output file from each stage that it seems to use as an indicator that the stage has completed, and that it's ok to move to the next stage, so perhaps this fulfills that need.
drewoldag
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic version of LephareInformer and relates to issue 4:
Issue/4/create base lephareinformer class
I added a .para file locally in the repo. Some of the config values are then overwritten I think to use different values for stars, galaxies and quasars. This is not ideal. I also still feel the use of environment variables for the auxiliary files and working directories a little eccentric.
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added