Adding some initial thoughts on goals for Twinkles that can be #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
translated into designs new file: planForTwinkles3.md
drphilmarshall
requested changes
Sep 29, 2016
There was a problem hiding this comment.
This looks good to me, Rahul. Can you rename the file to be SNgoals.md, please? It looks to me as though a sample of size ~1000 should be plenty for this work: you can slice and dice 1000 systems into say 30 bins of 30 objects each, which should be fine for estimating variances. Does that logic make sense?
drphilmarshall
approved these changes
Sep 29, 2016
|
Huh - I got confused by the new review UI, sorry! I wanted to view my report, and didn't realize that it was already visible as a comment in this thread... I'll see if I can change the status to "changes requested" again... |
drphilmarshall
requested changes
Sep 29, 2016
modified: SNgoals.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding initial thoughts for SN goals that we should try with Twinkles. Not quite ready for merge, but feedback would be good.
new file: planForTwinkles3.md