Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hardcoded propID variable to version dependent propID. #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Nov 5, 2018

  1. Fix the hardcoded propID variable to version dependent propID.

    Actually introduced new static method `get_propIDVals` making the
    former `propIDVals` method defunkt. A name change was useful and I
    fixed this in the new method. The old one has not been removed but
    probably could be.
    
    TODO:
    - remove the old function
    - Check the method `get_propIDDict` which does not seem to use OpSimVars
      and hopefully update it.
    - Check the number of methods that can be removed.
    
    Fixes #288
    	modified:   opsimsummary/opsim_out.py
    	modified:   opsimsummary/version.py
    rbiswas4 committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2b0fb28 View commit details
    Browse the repository at this point in the history