Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Interface Improvements (Experiment/better_parsing) #100

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

microstrain-sam
Copy link
Collaborator

@microstrain-sam microstrain-sam commented Apr 29, 2024

Changes:

  • mip_interface_recv_from_device no longer passes a buffer. Instead, user must call mip_interface_input_bytess with their own buffer of data.
  • Parser constructor no longer requires/accepts a buffer (parser is now fully stand-alone).
  • Removed optional limit on max packets per parse call. User can instead limit number of bytes sent to the parser.
  • mip_parser_parse and related functions return void because they always consume the entire buffer.
  • Parser callback now must return void (early abort not supported anymore as its probably not that useful)
  • Parser performance improvements (reduced copying, use memcpy, memchr)
  • Updated examples/tests accordingly.

@microstrain-sam microstrain-sam changed the title MIP Parsing Improvements (Experiment/better_parsing) Device Interface Improvements (Experiment/better_parsing) Apr 29, 2024
@microstrain-sam microstrain-sam changed the base branch from develop to develop_v3 April 29, 2024 17:37
@microstrain-sam microstrain-sam added blocked Waiting for something enhancement New feature or request labels May 9, 2024
@microstrain-sam microstrain-sam changed the base branch from develop_v3 to develop September 25, 2024 15:05
@microstrain-sam microstrain-sam removed the blocked Waiting for something label Nov 5, 2024
@microstrain-sam microstrain-sam marked this pull request as ready for review November 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant