Merge pull request #2 from LMacPhail/implement-ui

fix build warnings
LMacPhail · Nov 1, 2023 · 4d34798 · 4d34798
2 parents 50ec768 + 21897ae
commit 4d34798
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/src/components/Header.tsx b/src/components/Header.tsx
@@ -1,4 +1,5 @@
 import React from "react";
+import { ProjectTitle } from "./ProjectTitle";
 
 export const Header: React.FC = () => {
   return (
@@ -8,13 +9,7 @@ export const Header: React.FC = () => {
         aria-label="Global"
       >
         <div className="mr-5 md:mr-0 md:hidden">
-          <a
-            className="flex-none text-xl font-semibold dark:text-white"
-            href="#"
-            aria-label="Brand"
-          >
-            Labour MPs
-          </a>
+          <ProjectTitle />
         </div>
 
         <div className="w-full flex items-center justify-end ml-auto sm:justify-between sm:gap-x-3 sm:order-3">

diff --git a/src/components/ProjectTitle.tsx b/src/components/ProjectTitle.tsx
@@ -1,11 +1,10 @@
 import React from "react";
 
-export const ProjectTitle = () => (
-  <a
+export const ProjectTitle: React.FC = () => (
+  <div
     className="flex-none text-xl font-semibold dark:text-white"
-    href="#"
     aria-label="Brand"
   >
     Labour MPs
-  </a>
+  </div>
 );
diff --git a/src/components/Sidebar.tsx b/src/components/Sidebar.tsx
@@ -1,6 +1,4 @@
 import React from "react";
-import { ProjectTitle } from "./ProjectTitle";
-import { Filters } from "./filters/Filters";
 
 export const Sidebar: React.FC<{ children: React.ReactNode }> = ({
   children,