remove dead boundary condition code #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think this will fix #1207 |
Oops, maybe I misspoke in the meeting earlier, but this PR was originally motivated by looking at that issue, but doesn't fix it yet. The failing test is built on a part of the Although, it may be worth just deleting that failing test, since it doesn't appear to be testing the correctness of anything. |
tupek2
approved these changes
Aug 13, 2024
|
is this ready? i can approve. |
chapman39
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot (if not most) of the code in the boundary condition class appears to be unused and/or untested (at least in serac), this is just a PR that removes some of that old code.