Fix MPI support and Shared lib option in Caliper package #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaroncblack
approved these changes
Oct 26, 2023
|
@adrienbernede who needs to review this for you to merge it? |
|
Anyone :) |
|
Oops, it seems it's not taking your approval. I'll have a look at the settings. But for this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #75
@aaroncblack, the fix here is only slightly different that your suggested changes.
Please note that I am working on integrating our local packages to spack. It’s essentially ready. If you want to test it, you can use the
llnl/radiuss-packages-updatebranch in Spack.Warning !
This is tested here: LLNL/Caliper#507
Test are passing except on Tioga. I suspect our MPI setup for tioga may be wrong (in https://github.com/LLNL/radiuss-spack-configs/blob/main/toss_4_x86_64_ib_cray/packages.yaml). I think the Caliper package itself is OK.