Add element stride calculation and alignment methods #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds three new methods to the DataType class that help with element-based stride calculations and alignment checks: 1. element_stride(): Returns stride in elements instead of bytes 2. is_stride_element_aligned(): Tests if stride is aligned with element boundaries 3. is_stride_aligned(nbytes): Tests if stride is a multiple of given bytes Fixes issue #1207 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
cyrush
commented
Mar 27, 2025
| dt.set(DataType::FLOAT64_ID, | ||
| 10, // 10 elements | ||
| 0, // 0 offset | ||
| sizeof(float64)*2, // stride = 16 bytes (2 elements) |
Added Python bindings and tests for: - element_stride() - is_stride_element_aligned() - is_stride_aligned() Part of #1207 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Added C bindings and tests for: - element_stride() - is_stride_element_aligned() - is_stride_aligned() Part of #1207 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Added Fortran bindings and tests for: - element_stride() - is_stride_element_aligned() - is_stride_aligned() Part of #1207 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
cyrush
commented
Mar 27, 2025
| @@ -144,6 +144,14 @@ subroutine t_node_datatype_ids | |||
| call assert_true( conduit_datatype_element_bytes(dataType) == 8) | |||
| call assert_true( conduit_datatype_stride(dataType) == 8) | |||
| call assert_true( conduit_datatype_offset(dataType) == 0) | |||
|
|
|||
| ! Test the new element stride methods | |||
There was a problem hiding this comment.
Suggested change
| ! Test the new element stride methods | |
| ! Test the element stride methods |
cyrush
commented
Mar 27, 2025
| @@ -257,7 +257,57 @@ def test_to_string_and_friends(self): | |||
| self.assertEqual(d.to_string("yaml"),d.to_yaml()) | |||
| self.assertEqual(d.to_string("json"),d.to_json()) | |||
|
|
|||
|
|
|||
| def test_stride_methods(self): | |||
There was a problem hiding this comment.
Suggested change
| def test_stride_methods(self): | |
| def test_element_stride_methods(self): |
cyrush
commented
Mar 27, 2025
| return cpp_datatype_ref(cdatatype).is_stride_element_aligned() ? 1 : 0; | ||
| } | ||
|
|
||
| int conduit_datatype_is_stride_aligned(const conduit_datatype *cdatatype, conduit_index_t nbytes) |
There was a problem hiding this comment.
int return is consistent with other c api functions that provide boolean answers
|
|
Give the state of the world today, |
I want to respond with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds three new methods to the DataType class that help with element-based stride calculations and alignment checks:
Fixes issue #1207
🤖 Generated with Claude Code