Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New caliper modifier implementation #618

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Feb 14, 2025

Work in progress. This PR changes the caliper modifier implementation (Solves #603)
In the existing caliper modifier, we define caliper modes to collect specific metrics (e.g. cuda, mpi, time etc)
The current benchpark implementation sets these modes at experiment init time. Each of these modes creates an environment variable in the experiment bash script to collect the desired metrics. However, this approach does not facilitate benchmark-specific changes as the caliper modifier is processed during the Ramble setup phase.

In the new impementation, we use the caliper modes specified on experiment init to directly set the required variables in the experiment ramble.yaml. The generated ramble.yaml is functionally equivalent to the one generated by the existing caliper modifier. However, this approach allows for changes to the caliper config at benchmark init time.

  • Replace with: A short description of the change, including motivation and context.

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • Tags in Ramble's application.py or in repo/benchmark_name/application.py will appear in the docs catalogue
  • Add/modify an experiments/benchmark_name/experiment.py to define a single node and multi-node experiments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant