Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move caliper from experiment to lib #577

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Move caliper from experiment to lib #577

merged 1 commit into from
Jan 28, 2025

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Jan 27, 2025 •
edited by slabasan
Loading

Description

  • This PR moves the caliper experiment config from experiments/caliper/experiment.py to lib/benchpark/caliper.py
  • No dependencies
  • Fixes Move caliper/experiment.py into lib #576
  • Complete the checklist for a relevant section(s) below
  • Delete sections below that are not relevant to this PR

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • (optional) If package upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py
  • (optional) If application upstreamed to Ramble is insufficient, add/modify repo/benchmark_name/application.py
  • Tags in Ramble's application.py or in repo/benchmark_name/application.py will appear in the docs catalogue
  • Add/modify an experiments/benchmark_name/experiment.py to define a single node and multi-node experiments
  • Add/modify a dry run unit test in .github/workflows/run.yml

@rfhaque rfhaque requested a review from pearce8 January 27, 2025 21:13
@github-actions github-actions bot added the experiment New or modified experiment label Jan 27, 2025
@slabasan slabasan marked this pull request as ready for review January 27, 2025 21:19
@pearce8 pearce8 merged commit e3e451f into develop Jan 28, 2025
16 checks passed
@pearce8 pearce8 deleted the fix/move_caliper_to_lib branch January 28, 2025 00:06
@pearce8 pearce8 mentioned this pull request Jan 28, 2025
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearce8 pearce8 pearce8 approved these changes

Assignees
No one assigned
Labels
experiment New or modified experiment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move caliper/experiment.py into lib
2 participants
@rfhaque @pearce8